On 2018/9/10 3:27 PM, Alan Bateman wrote:
On 10/09/2018 08:19, Amy Lu wrote:
test/jdk/java/util/zip/ZipFile/deletetempjar.sh
Please review this patch to refactor above shell script test to java.
bug: https://bugs.openjdk.java.net/browse/JDK-8209930
webrev: http://cr.openjdk.java.net/~amlu/8209930/webrev.00/
This okay as a replacement but it can be a bit fragile sometimes to
use the output of the sub-process. Just thinking about warnings or
other output in non-product builds that might be sent to stdout rather
than stderr. An alternative would be DeleteTempJarTest to create a
listener socket and have DeleteTempJar connect to send the file name -
we can go there is any issues arise.
Good point!
How about to resolve it later in a separate issueto-be-filed?
Thanks,
Amy
-Alan
