On 12/09/2018 08:22, Amy Lu wrote:
test/jdk/java/util/ServiceLoader/basic/basic.sh

Please review this patch to refactor above shell script test to java.

bug: https://bugs.openjdk.java.net/browse/JDK-8209772
webrev: http://cr.openjdk.java.net/~amlu/8209772/webrev.00/
This looks okay to me but it isn't immediately clear if the output/error streams from the launched VMs will be in the .jtr file. In other tests we have used the OutputAnalyzer's outputTo and errorTo and I wonder if it's needed here.

-Alan

Reply via email to