Hi Mandy, yes, eventually I'd like to see this library being used in place of ASM in our tests. I ain't planning to do it in JDK 12 TF though.
if there is a newer version ready, I'm happy to update (and test) the library, although it shouldn't block testlibraries "merge" activity. -- Igor > On Sep 19, 2018, at 3:32 PM, mandy chung <mandy.ch...@oracle.com> wrote: > > Hi Igor, > > Are you planning to convert the hotspot tests to use this bytecode library? > > This bytecode library is one version that was snapshot when these condy tests > were integrated in JDK. It has likely been evolved. Maurizio and Robert > may > comment on this whether this bytecode library is ready to open for more tests > to use. When the bytecode library is updated to a newer version. > > Mandy > > On 9/19/18 2:37 PM, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8210925/webrev.00/index.html >> <http://cr.openjdk.java.net/~iignatyev//8210925/webrev.00/index.html> >>> 14 lines changed: 0 ins; 0 del; 14 mod; >> Hi all, >> >> could you please review this small and trivial patch which moves bytecode >> testlibrary to top-level testlibrary directory? >> >> webrev: http://cr.openjdk.java.net/~iignatyev//8210925/webrev.00/index.html >> <http://cr.openjdk.java.net/~iignatyev//8210925/webrev.00/index.html> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8210925 >> <https://bugs.openjdk.java.net/browse/JDK-8210925> >> testing: java/lang/invoke/condy tests >> >> Thanks, >> -- Igor >
