There was a compilation error on Linux in one of the tests:
test/jdk/java/lang/Floating/DoubleToDecString.java:133: error: unmappable
character (0x93) for encoding US-ASCII
Paxson V, "A Program for Testing IEEE Decimal\ufffd\ufffd\ufffdBinary
Conversion"
This was only in one of the comments where it looks like some errant character
leaked in. I updated the webrev (with accompanying patch) in place [1] after
verifying that the change to the test fixes the problem.
Also, there were a couple of failures observed in test [2] at lines 172 and
173. If at line 172 "foo1.17549435E-38” is changed to "foo1.1754944E-38” then
the evaluation at that line succeeds but then the one at line 173 fails. Making
a similar change on this line does not help. I suspect that this is due to a
difference between the new code and that in jdk.internal.math.FloatingDecimal
which is used by java.lang.AbstractStringBuilder and
java.lang.invoke.StringConcatFactory but I’ve not actually investigated this as
yet. I had actually wondered whether some or all of the FloatingDecimal code
could be superseded by the updated logic.
Brian
[1] http://cr.openjdk.java.net/~bpb/4511638/webrev.00/
[2] java/lang/String/concat/ImplicitStringConcatBoundaries.java
