Agree, please find updated webrev[1]. [1] http://cr.openjdk.java.net/~henryjen/jdk/8210810/1/webrev/
Cheers, Henry > On Sep 27, 2018, at 1:45 AM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 27/09/2018 03:58, Henry Jen wrote: >> Hi, >> >> Need a quick review of the webrev[1] for JDK-8210810[2], it’s pretty much >> what Bo contributed, just add some trailing text “aaa\” to verify the >> integrity of escape sequence is handled properly. >> >> I had reviewed the change and tested, but we need a “R”eviewer. >> >> Cheers, >> Henry >> >> [1] http://cr.openjdk.java.net/~henryjen/jdk/8210810/webrev/ >> [2] https://bugs.openjdk.java.net/browse/JDK-8210810 >> >> > The change to args.c looks okay but for the test then I assume it would be > better to just add another test case to the existing ArgFileSyntax.java. > > -Alan
