Ping... Are there any reviews/comments on my proposal for adding unix/posix permissions to zip APIs?
Thanks Christoph > -----Original Message----- > From: Langer, Christoph > Sent: Mittwoch, 26. September 2018 09:49 > To: 'Alan Bateman' <alan.bate...@oracle.com>; core-libs- > d...@openjdk.java.net; nio-dev <nio-...@openjdk.java.net>; Xueming > Shen <xueming.s...@oracle.com> > Cc: Volker Simonis <volker.simo...@gmail.com>; Lindenmaier, Goetz > <goetz.lindenma...@sap.com> > Subject: RE: RFR (Enhancement): 6194856: Zip Files lose ALL ownership and > permissions of the files > > Hi Alan, > > thanks for your initial comments. > > > One initial comment is that you should be able to drop the API additions to > > PosxFilePermissions - I think all you need there translation from > > Set<PosixFilePermission> to internal values, it doesn't require bloating the > > API. > > I agree, it doesn't feel right to bloat PosixFilePermissions with details > needed > for zip operations. > > I now moved this coding to the ZipUtils classes. The only drawback is the > duplication of the code but there's already quite some duplication of coding > between java.util.zip and jdk.nio.zipfs. > > Here is an updated webrev: > http://cr.openjdk.java.net/~clanger/webrevs/6194856.1/ > > Best regards > Christoph
