On 10/3/18, 6:43 AM, Alan Bateman wrote:


On 02/10/2018 21:04, Xueming Shen wrote:
Hi,

Please help review the change for JDK-8211585.

issue: https://bugs.openjdk.java.net/browse/JDK-8211385
webrev: http://cr.openjdk.java.net/~sherman/8211385/webrev
This looks okay although it might be cleaner for iteratorOf to take the directory as a parameter rather than path and a flag.

-Alan.
Thanks Alan!

Take a second look, since the "resolved" is cached in ZipPath, it appears the
"path" is actually not necessary. "ZipPath dir" is good enough here.

Webrev has been updated accordingly.

http://cr.openjdk.java.net/~sherman/8211385/webrev/

sherman

Reply via email to