Hi Jaikiran,

"wrap to throw a IOE" appears good. I will sponsor this patch.

Thanks!
-Sherman

On 10/5/18, 8:31 AM, Jaikiran Pai wrote:
Thank you Chris.

I've attached a patch here which catches the InvalidPathException within
the implementation of ZipFile and wraps and throws a IOException. It's
the same patch which I mentioned earlier in this thread, but now also
includes jtreg testcase to reproduce the issue and verify the fix. I
have run the jtreg test with and without this patch on my *nix system
and it behaves as expected (fails without the fix and passes with it). I
don't have a Windows OS at hand to test this patch and the testcase on it.

I also did a very basic check and went through the JarFile/ZipFile
constructor code path to see if there are other places in that flow
which might need similar treatment. My not-so-thorough check didn't show
up any other such instance.

Could I please get help from someone who can sponsor this patch and help
with the review too?

-Jaikiran


On 05/10/18 6:21 PM, Chris Hegarty wrote:
On 5 Oct 2018, at 12:08, Jaikiran Pai<jai.forums2...@gmail.com>  wrote:

I don't have access to create an issue for this in OpenJDK JIRA, so I'll
go ahead and create one at bugs.java.com.

I just submitted the report. Internal review id 9057522 has been
assigned to the issue.
And now in the JDK project:

   https://bugs.openjdk.java.net/browse/JDK-8211765

-Chris.

Reply via email to