Hi Pavel,
Looks fine.
The JNICALL macro is used by the C compiler to force a particular native
calling convention (API).
ABI - Application binary interface that defines the stack and register
usage when calling native functions.
On Windows it is defined as __stdcall, which is the default so there is
no change in behavior if it is missing.
See src/java.base/*/native/include/jni_md.h
It seems most native function declarations include JNICALL.
Possibly this should be a separate cleanup but being consistent within
each native source file would be a good start.
Roger
On 10/11/2018 08:30 AM, Chris Hegarty wrote:
On 11 Oct 2018, at 13:28, Pavel Rappo <[email protected]> wrote:
Hello,
Please review the following change:
http://cr.openjdk.java.net/~prappo/8212001/webrev.00
<http://cr.openjdk.java.net/~prappo/8212001/webrev.00>
This looks good. Thanks Pavel.
-Chris.
