Re: RFR(JDK 12/NIO) 8202285: (fs) Add a method to Files for comparing file contents

[Weijun Wang]

> On Oct 16, 2018, at 6:14 AM, Joe Wang <huizhe.w...@oracle.com> wrote:
> 
> 
> 
> On 10/14/18, 6:48 PM, Weijun Wang wrote:
>> Hi Joe
>> 
>> Two comments:
>> 
>> 1. How about (path1, path2)? I take a look at other similar APIs, some use 
>> (c1,c2) and some (a,b).
> 
> It's true we have some inconsistencies there. Arrays.mismatch for example, 
> named the parameters (a,b). Arguably though, they should have been (a, a2) if 
> they wanted to maintain consistency with then existing "equals" methods. In 
> our case, since Files.isSameFile was (path, path2), Files.mismatch(path, 
> path2) is desirable since it is extending the former's functionality.

Oops, I didn't notice this one. You're right.

Thanks
Max