Looks fine Joe.
> On Nov 1, 2018, at 12:45 AM, Joe Wang <huizhe.w...@oracle.com> wrote: > > Thanks Lance! I somehow copied the wrong link. Although they point to the > same document, the shorter version (without the prefix and date) is better. Yes saw that. Best to change though unless that is a temporary URL > Fixed now in the webrev: > webrev: http://cr.openjdk.java.net/~joehw/jdk12/8212871/webrev/ > <http://cr.openjdk.java.net/~joehw/jdk12/8212871/webrev/> > > Thanks, > Joe > > On 10/31/18, 5:14 PM, Lance Andersen wrote: >> >> BTW >> >> This seems to only be for: >> >> --- old/src/jdk.xml.dom/share/classes/org/w3c/dom/xpath/XPathNamespace.java >> 2018-10-31 16:49:00.265127157 -0700 >> +++ new/src/jdk.xml.dom/share/classes/org/w3c/dom/xpath/XPathNamespace.java >> 2018-10-31 16:48:59.861089532 -0700 >> @@ -74,7 +74,7 @@ >> * future versions of the XPath specification, the definition of a namespace >> * node may be changed incomatibly, in which case incompatible changes to >> * field values may be required to implement versions beyond XPath 1.0. >> - * <p>See also the <a >> href='http://www.w3.org/2002/08/WD-DOM-Level-3-XPath-20020820 >> <http://www.w3.org/2002/08/WD-DOM-Level-3-XPath-20020820>'>Document Object >> Model (DOM) Level 3 XPath Specification</a>. >> + * <p>See also the <a >> href='https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/ >> <https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/>'>Document >> Object Model (DOM) Level 3 XPath Specification</a>. >> */ >> >>> On Oct 31, 2018, at 8:09 PM, Lance Andersen <lance.ander...@oracle.com >>> <mailto:lance.ander...@oracle.com>> wrote: >>> >>> Hi Joe, >>> >>> I see the update as >>> >>> https://www.w3.org/TR/DOM-Level-3-XPath/ >>> <https://www.w3.org/TR/DOM-Level-3-XPath/> >>> and >>> >>> https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/ >>> <https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/> >>> <https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/> >>> <https://www.w3.org/TR/2004/NOTE-DOM-Level-3-XPath-20040226/> >>> >>> Was that intentional? >>> >>> >>>> On Oct 31, 2018, at 8:02 PM, Joe Wang <huizhe.w...@oracle.com> >>>> <mailto:huizhe.w...@oracle.com> wrote: >>>> >>>> Hi, >>>> >>>> Please review a fix for the broken links, replacing: >>>> http://www.w3.org/2002/08/WD-DOM-Level-3-XPath-20020820 >>>> <http://www.w3.org/2002/08/WD-DOM-Level-3-XPath-20020820> >>>> with: >>>> https://www.w3.org/TR/DOM-Level-3-XPath/ >>>> <https://www.w3.org/TR/DOM-Level-3-XPath/> >>>> >>>> The former on which the jdk.xml.dom package was based is no longer >>>> publicly available. The later is current. The only difference between the >>>> two was noted in the package info ( >>>> src/jdk.xml.dom/share/classes/org/w3c/dom/xpath/package-info.java), and >>>> also in XPathException.java in this webrev. >>>> >>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8212871 >>>> <https://bugs.openjdk.java.net/browse/JDK-8212871> >>>> webrev: http://cr.openjdk.java.net/~joehw/jdk12/8212871/webrev/ >>>> <http://cr.openjdk.java.net/~joehw/jdk12/8212871/webrev/> >>>> >>>> Thanks, >>>> Joe >>>> >>> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >>> Principal Member of Technical Staff | +1.781.442.2037 >>> Oracle Java Engineering >>> 1 Network Drive >>> Burlington, MA 01803 >>> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> >>> <mailto:lance.ander...@oracle.com> <mailto:lance.ander...@oracle.com> >>> >>> >>> >> >> <Mail Attachment.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| >> Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com <mailto:lance.ander...@oracle.com> >> >> >> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
