+1
On 11/01/2018 04:55 PM, Lance Andersen wrote:
ship it :-)
On Nov 1, 2018, at 4:51 PM, Naoto Sato <naoto.s...@oracle.com> wrote:
Indeed. Added the period.
http://cr.openjdk.java.net/~naoto/8213046/webrev.02/
Naoto
On 11/1/18 1:03 PM, Lance Andersen wrote:
Looks better. Unless it is my eyes, the period seems missing after the blog
URL.
On Nov 1, 2018, at 3:53 PM, Naoto Sato <naoto.s...@oracle.com
<mailto:naoto.s...@oracle.com>> wrote:
Updated the webrev. Dropped the "," after "May" too.
http://cr.openjdk.java.net/~naoto/8213046/webrev.01/
<http://cr.openjdk.java.net/%7Enaoto/8213046/webrev.01/>
Naoto
On 11/1/18 11:31 AM, Naoto Sato wrote:
Hi Lance,
On 11/1/18 11:26 AM, Lance Andersen wrote:
Hi Naoto
+ * The code point, U+32FF, is reserved by the Unicode Consortium
+ * to represent the Japanese square character for the new era that begins
+ **from* May, 2019. Relevant methods in the Character class return the same
+ * properties as for the existing Japanese era characters (e.g., U+337E for
+ * "Meizi"). For the details of the code point, refer to
+ * <a href="http://blog.unicode.org/2018/09/new-japanese-era.html";>
+ *http://blog.unicode.org/2018/09/new-japanese-era.html</a>
<http://blog.unicode.org/2018/09/new-japanese-era.html%3C/a%3E>
Is “from” needed in the the above or could it be
… era that begins May, 2019 ?
OK, will remove that "from".
Also is there a change that the URL for the blog could disappear or are they
typically a constant and do not change
That blog is an official one from Unicode Consortium. The subtitle of it reads
"NEWS, ANNOUNCEMENTS, RELEASE INFO, AND CALENDAR UPDATES FROM THE UNICODE
CONSORTIUM", so I don't expect the entry to disappear without any apparent reason.
Naoto
On Nov 1, 2018, at 2:11 PM, Naoto Sato <naoto.s...@oracle.com
<mailto:naoto.s...@oracle.com>> wrote:
Hello,
Please review a javadoc fix to this issue:
https://bugs.openjdk.java.net/browse/JDK-8213046
The proposed change is located at:
http://cr.openjdk.java.net/~naoto/8213046/webrev.00/
This is to clarify the previously pushed change (8211398) in the javadoc of
Character class.
Naoto
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
