Hi Bernd, I agree to both of your comments and will update my code with the changes.
Thanks, Smita From: Bernd Eckenfels [mailto:e...@zusammenkunft.net] Sent: Monday, November 19, 2018 2:27 PM To: Kamath, Smita <smita.kam...@intel.com>; 'Vladimir Kozlov' <vladimir.koz...@oracle.com> Cc: core-libs-dev@openjdk.java.net; security-...@openjdk.java.net Subject: Re: RFR(S)JDK-8214074: Ghash optimization using AVX instructions Hello, What is the purpose of setting some of them to 0 twice? (It's a new array which should be all-0 anyway.) + for (int i = 1; i < 9 ; i++) { + subkeyHtbl[2*i] = 0; + subkeyHtbl[2*i+1] = 0; + } Also, is the subkeyH no longer be needed (or can be redesigned to use subkeyHtbl[0] and 1? Gruss Bernd -- http://bernd.eckenfels.net ________________________________ Von: core-libs-dev <core-libs-dev-boun...@openjdk.java.net<mailto:core-libs-dev-boun...@openjdk.java.net>> im Auftrag von Kamath, Smita <smita.kam...@intel.com<mailto:smita.kam...@intel.com>> Gesendet: Montag, November 19, 2018 10:52 PM An: 'Vladimir Kozlov' Cc: Anthony Scarpino; core-libs-dev@openjdk.java.net<mailto:core-libs-dev@openjdk.java.net>; hotspot compiler Betreff: RFR(S)JDK-8214074: Ghash optimization using AVX instructions Hi Vladimir, I'd like to contribute an optimization for GHASH Algorithm using AVX Instructions. I have tested this optimization on SKX x86_64 platform and it shows ~20-30% performance improvement for larger message sizes (for example 8k). I, smita.kam...@intel.com<mailto:smita.kam...@intel.com<mailto:smita.kam...@intel.com%3cmailto:smita.kam...@intel.com>> , Shay Gueuron, (shay.gue...@intel.com<mailto:shay.gue...@intel.com<mailto:shay.gue...@intel.com%3cmailto:shay.gue...@intel.com>>) and Regev Shemy (regev.sh...@intel.com<mailto:regev.sh...@intel.com<mailto:regev.sh...@intel.com%3cmailto:regev.sh...@intel.com>>) are contributors to this code. Link to Bug: https://bugs.openjdk.java.net/browse/JDK-8214074 Link to webrev: http://cr.openjdk.java.net/~svkamath/ghash/webrev/ For testing the implementation, I have executed TestAESMain.java. I have executed Jtreg tests and tested this code on 64 bit Windows and Linux platforms. Please review and let me know if you have any comments. Thanks and Regards, Smita
