Hi Naoto,

Look ok.

java/util/ResourceBundle.java: 3187
  The comment isn't strictly correct since the block applies to named (and open) modules too.

[I think I would complete the conversion of the test to java to know
that it was working and not wait for 8213127].

Thanks, Roger


On 11/26/2018 08:07 PM, Naoto Sato wrote:
Hi,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8214170

The proposed changeset is located at:

http://cr.openjdk.java.net/~naoto/8214170/webrev.00/

The existing logic to determine if there is a pubic constructor for the ResourceBundle class is incorrect. Moved the catch clause for NoSuchMethodException to handle it correctly. A shell based test was modified according to this (intentionally omitted the case for windows as chmod does not work - it will be addressed with the test case clean up (8213127).

Naoto

Reply via email to