Mostly great.  I look forward to being able to use it (eventually) in tools like javac, javadoc.

Doc nits:

I would suggest using "Although" instead of "Though" in "Though the strings are typically filesystem paths", and since it follows "Note:" it does not need to be capitalized.

More significantly, structurally, the info about null and NPE is part of the @implNote, which is probably not what you intended.  I suggest moving that sentence ahead of the @implNote.

-- Jon


On 11/27/2018 12:09 PM, Roger Riggs wrote:
Please review a refreshed API for parsing search and using paths.
Thanks for the earlier comments and suggestions.

java.util.SearchPath is an immutable sequence of strings, typically filesystem paths. A search path is created from a list of strings or by splitting a string using File.pathSeparator.


Webrev: http://cr.openjdk.java.net/~rriggs/webrev-searchpath-8207690-1/

Javadoc: http://cr.openjdk.java.net/~rriggs/searchpath-8208208/java.base/java/util/SearchPath.html

Issue: https://bugs.openjdk.java.net/browse/JDK-8207690

CSR: https://bugs.openjdk.java.net/browse/JDK-8208208

Thanks, Roger


Reply via email to