On 2018-11-28 23:49, Henry Jen wrote:
Since there is no header file in JDK provides the function prototypes, I don’t
think this is considered public(supported) APIs.
Anyway, in case a tools is build with launcher code, and shipped separately
from JDK, that would be impacted by this bug. So I added a test call JLI_Launch
as well. Please review the updated webrev[1].
Note that, JLI_Launch should not be used directly as it does’t handle the
argument processing which is done in launcher/main.c.
Cheers,
Henry
[1] http://cr.openjdk.java.net/~henryjen/jdk12/8213362.1/webrev/
The build changes look good, as is the original fix for the problem. As
far as I can tell, the tests seem reasonable. At the very least, this is
a much better situation than we had before. So I say, ship it!
/Magnus
On Nov 28, 2018, at 5:28 AM, Kevin Rushforth <kevin.rushfo...@oracle.com> wrote:
On 11/28/2018 5:19 AM, Alan Bateman wrote:
On 28/11/2018 13:13, Kevin Rushforth wrote:
The jpackage tool calls JLI_Launch.
I remember that from Andy's webrev but it's not integrated yet. Does the JavaFX
packager tool do the same?
Yes, the javapackager tool (delivered via JavaFX) in JDK 8/9/10 calls
JLI_Launch.
-- Kevin
