Ali has scanned the code base, he says, “couldn’t find (hopefully tbh)
other occurrences of such mismatches.”
On 10/12/2018 10:45, Magnus Ihse Bursie wrote:
It might be worthwhile to scan the entire code base for JNICALL and
verify that we have no more mismatches. In general, JNICALL should be
preserved on all officially supported, exported interfaces. It need
not be present on interfaces used only internally, and my current
thinking is that it would be better if it were removed on all internal
interfaces. But at the very least, it should be consistently
specificed where exported and imported. (Any misses here is probably
due to duplicate declarations, instead of properly including header
files, so that's the correct way to resolve any problems found...)
--
Regards,
Alexey
