Hi Deeoak, The changes look fine.
Happy Holidays > On Dec 24, 2018, at 4:17 AM, Deepak Kejriwal <[email protected]> > wrote: > > Hi Mandy / Alan, > > > > Thanks for review. I have modified the ClassLoader.java as per the given > comments. > > > > Please find updated version of webrev:- > > > > http://cr.openjdk.java.net/~rpatil/8214567%2b8214569/webrev.01/ > > > > Regards, > > Deepak > > > > From: Mandy Chung > Sent: Friday, December 21, 2018 10:05 PM > To: Deepak Kejriwal <[email protected]> > Cc: core-libs-dev <[email protected]> > Subject: Re: [12] RFR: 8214567 and 8214569: Use {@systemProperty} for > definitions of system properties > > > > > > On 12/21/18 1:49 AM, Deepak Kejriwal wrote: > > Hi all, > > Please review the fix for following issues:- > > https://bugs.openjdk.java.net/browse/JDK-8214567 > > https://bugs.openjdk.java.net/browse/JDK-8214569 > > Below is the webrev for above issues: > > http://cr.openjdk.java.net/~rpatil/8214567%2b8214569/webrev.00/ > > > > Looks okay. > > Like Alan suggests, reformating line 1867 in ClassLoader.java to avoid that > single long line sticking out would be good. > > Mandy <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] <mailto:[email protected]>
