Hello.
Could you review the fix and give your suggestion ?
Thanks,
Ichiroh Takiguchi
On 2019-01-16 21:32, Ichiroh Takiguchi wrote:
Hello Alan and Roger.
I appreciate your suggestions.
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.02/
I used "hg cp" command.
If I should use git format, please let me know.
I changed Copyright year on IBM29626C.java.template and charsets file.
Thanks,
Ichiroh Takiguchi
On 2019-01-16 01:01, Roger Riggs wrote:
Hi,
I'd suggest using 2002, 2019, for the copyright, since much of the
code in the new
file comes from an older source.
$.02, Roger
On 01/15/2019 10:43 AM, Alan Bateman wrote:
On 15/01/2019 00:51, Ichiroh Takiguchi wrote:
Hello Alan.
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/
I added IBM29626C charset as standard way.
Please give any suggestion and question.
This looks okay, assuming it's `hg copy` of EUR_JP.template to create
IBM29626C.java.template rather than a `hg mv` (the webrev makes it
look like a move/rename).
-Alan
