On 1/24/19 12:48 PM, Lance Andersen wrote:
Hi all,

Please review the following patch which addresses 
https://bugs.openjdk.java.net/browse/JDK-8210469 where jdk.zipfs was missing a 
doPriviledged block and permission  needed when closing a zip file system when 
a security manager has been enabled.

The webrev can be found at: 
http://cr.openjdk.java.net/~lancea/8210469/webrev.00/index.html

Alternatively you can simply do:
            PrivilegedExceptionAction<Path> pea = () -> tempPath.toRealPath();
            return AccessController.doPrivileged(pea);

In this case, limited doPrivileged does not make whole lot of difference jdk.zip explicitly grants for limited permissions and this doPrivileged block is one single operation, toRealPath.

The new test has a couple of blank lines (line 64 an 83). Formatting nit: indentation in line 74.

Mandy

Reply via email to