This looks fine to me.

I note that it still allows characters that will cause problems (e.g., ":" on Linux or ";" on Windows), but that could be done as a follow-on bug.

-- Kevin


On 1/27/2019 4:56 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].

This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage).

The webrev includes removal of the APP_FS_NAME DeployParam, and enhanced  checking of the given application name so APP_NAME parameter can be safely used in all cases.

[1] https://bugs.openjdk.java.net/browse/JDK-8217331

[2] http://cr.openjdk.java.net/~herrick/8217331/

/Andy


Reply via email to