Looks good Pavel :-) > On Jan 29, 2019, at 7:28 PM, Pavel Rappo <pavel.ra...@oracle.com> wrote: > > Alan, Lance, > > I have created a webrev with the change: > > http://cr.openjdk.java.net/~prappo/8218022/webrev.00/ > > I added bonus fixes and updated the copyright years. If everybody is fine with > this change, I'm pushing it. > > List of locations of additional fixes added to Andrey's patch: > > sun.net.www.http.HttpClient#HttpClient(java.net.URL, java.lang.String, int) > jdk.internal.module.ServicesCatalog#create > jdk.internal.platform.Metrics#getCpuSetMemoryPressure > java.lang.invoke.MethodHandleNatives#linkMethod > > java.lang.LiveStackFrame#getStackWalker(java.util.Set<java.lang.StackWalker.Option>) > > -Pavel > > P.S. > > I also added a missing '*' to the sun.security.util.ConstraintsParameters top > level doc and removed the "on" preposition from the second sentence. The words > seemed to be out of order: "on passed" instead of "passed on". > > It might look even better if we remove this preposition completely: > > ... > * This is currently passed between PKIX, AlgorithmChecker, > * and DisabledAlgorithmConstraints. > */ > public class ConstraintsParameters { >
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
