On 1/30/2019 5:22 PM, Mandy Chung wrote:
On 1/30/19 5:27 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8217793 fixes the use of modular jars
[1] https://bugs.openjdk.java.net/browse/JDK-8217793
[2] http://cr.openjdk.java.net/~herrick/8217793/webrev.01/
It'd be good to have a regression test along with the fix.
It's in a sandbox and of course no issue to add later but
it's better to start adding regression tests to catch any
regression in the future.
Mandy
I will put this back to sandbox as is (without regression test for now)
but I have added note in JDK-8213558
<https://bugs.openjdk.java.net/browse/JDK-8213558>: "Create more unit
and regression tests" to cover this case.
/Andy
