Hi Christoph
Thank you for the feedback, Please see below
> On Feb 5, 2019, at 11:22 AM, Langer, Christoph <christoph.lan...@sap.com>
> wrote:
>
>>> *
>>> + * The {@linkplain java.nio.file.FileSystems FileSystems} {@code
>> newFileSystem}
>>> + * static factory methods can be used to create a new Zip file system or to
>>> + * obtain a reference to an existing Zip file system.
>> or "can be used to create a zip file system or open an existing file as
>> a zip file system".
>
> Here I think Lance's point is what would happen when a FileSystem instance
> for a particular zip file would already exist and a call to newFileSystem
> would throw a FileSystemAlreadyExistsException. In that case you need to call
> getFileSystem. So maybe this sentence should be reworked to cover everything?
This only appears to be the case when using a URI not a Path, so for now I
suggest we leave it as is based on the last changes
>
>>>
>
> I'm also wondering, whether we should mention how the FileSystemProvider
> instance can be resolved (e.g. iterating
> FileSystemProvider.installedProviders(), checking for scheme "jar")? Not
> quite sure…
I had included that originally, but Alan and I discussed that off line prior to
the original RFR and we decided it was not needed for the average developer so
I removed it prior to the RFR.
Best
Lance
>
> Best regards
> Christoph
>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
