Hi Andy,
http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java.frames.html
Line 108 and 113 looks same. I think one of them can be removed.
http://cr.openjdk.java.net/~herrick/8217894/webrev.01/src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties.frames.html
Line 84 - "Specifies the type of the installer created in create-image
mode", I think it should be "created in create-installer mode".
Otherwise looks fine.
Thanks,
Alexander
On 2/5/2019 8:06 AM, Andy Herrick wrote:
Please review the jpackage fix for [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
In response to internal and external feedback, the following syntax
changes are being made to jpackage Command Line Interface (CLI):
1.) remove "create-jre-installer <type>" mode, and add
--runtime-installer option.
2.) remove the <type> arg from create-image mode, and add
--installer-type option.
3.) rename the --class option to --main-class
4.) remove the --limit-modules option
5.) rename the --force option to --overwrite and improve it's help text.
[1] https://bugs.openjdk.java.net/browse/JDK-8217894
[2] http://cr.openjdk.java.net/~herrick/8217894/webrev.01/index.html
/Andy
