On 2/6/19 12:22 PM, Brian Burkhalter wrote:
Hi Mandy,

I verified that running the script generates the same test files which are checked in to the repo, as it should be.

Thanks for verifying.  The tests shown in the webrev are generated
by the script, not manually edited.

Someone else should review the actual test template content however.

Vicente will review it too.

thanks
Mandy

Thanks,

Brian

On Feb 6, 2019, at 12:13 PM, Mandy Chung <mandy.ch...@oracle.com <mailto:mandy.ch...@oracle.com>> wrote:

This patch fixes up X-VarHandleTest* template files that are
used to generate VarHandles tests.  Since VarHandle::equals
and VarHandle::hashCode methods are no longer implemented [1],
I rename the testEqualsAndHashCode method to testEquals
and further clean up the test case.

Webrev:
http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8218461/webrev.00/

Thanks
Mandy
[1]https://bugs.openjdk.java.net/browse/JDK-8215648

Reply via email to