Hi Daniel > On Feb 14, 2019, at 2:10 PM, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi, > > Please find below a doc fix for: > > 8216363: NullPointerException in java.util.logging.Handler#isLoggable > https://bugs.openjdk.java.net/browse/JDK-8216363 > > webrev: > http://cr.openjdk.java.net/~dfuchs/webrev_8216363/webrev.00/index.html > > java.util.logging.Handler specifies that Handler.isLoggable(null) > returns false. Unfortunately, the implementation throws NPE instead. > > For the sake of backward compatibility - it might be more > prudent to simply alter the API specification to document > the behavior of the default implementation, while allowing > subclasses to change that behavior. In fact, one already > does: StreamHandler::isLoggable(LogRecord) already returns > false and doesn't throw NPE.
Documenting the current behavior as it has been makes the most sense to me as well Have you created a CSR yet? if so I will add myself as a reviewer? > > > best regards, > > -- daniel <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
