Looks good.
regards,
Sean.
On 21/02/2019 08:54, Deepak Kejriwal wrote:
Hi Naoto,
Corrected the exception message. Please find below updated version of webrev:-
http://cr.openjdk.java.net/~rpatil/JapaneseEra_and_Currency_changes_8u/webrev.02/
Thanks for review.
Regards,
Deepak
-----Original Message-----
From: Naoto Sato
Sent: Wednesday, February 20, 2019 11:07 PM
To: Deepak Kejriwal <deepak.kejri...@oracle.com>; Sean Coffey
<sean.cof...@oracle.com>; core-libs-dev <core-libs-dev@openjdk.java.net>;
jdk8u-...@openjdk.java.net
Subject: Re: RFR: JDK8U JDK-8202088, JDK-8207152, JDK-8211398, JDK-8180469,
JDK-8206120, JDK-8218915, JDK-8217710
Hi Deepak,
The same comment for 11u can be applied here too:
> - Line 163,198: Exception messages are incorrect. they are for
isJavaIdentifierStart().
Naoto
On 2/20/19 8:57 AM, Deepak Kejriwal wrote:
Thanks Naoto San and Sean for review. I have incorporate all the
comments. Please find below updated version of webrev :-
http://cr.openjdk.java.net/~rpatil/JapaneseEra_and_Currency_changes_8u
/webrev.01/
Regards,
Deepak
-----Original Message-----
From: Naoto Sato
Sent: Tuesday, February 19, 2019 10:40 PM
To: Deepak Kejriwal <deepak.kejri...@oracle.com>; core-libs-dev
<core-libs-dev@openjdk.java.net>; jdk8u-...@openjdk.java.net
Subject: Re: RFR: JDK8U JDK-8202088, JDK-8207152, JDK-8211398,
JDK-8180469, JDK-8206120, JDK-8218915, JDK-8217710
Hi Deepak,
Almost all the comments for the 11u changes [1] applies here, except the "newCodePoint" comment.
For this one, I'd suggest renaming "newCodePoints" to "UNASSIGNED_CODEPOINTS_IN_6_2"
Naoto
[1]
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-February/05
8610.html
On 2/19/19 5:55 AM, Deepak Kejriwal wrote:
Hi All,
Please review the backport of the following bug fixes to jdk8u-dev:
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8202088"JDK-8202088:
Japanese new era implementation.
HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8207152"JDK-8207152:
Placeholder for Japanese new era should be two characters.
HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8211398"JDK-8211398 :
Square character support for the Japanese new era HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8180469"JDK-8180469 : Wrong
short form text for supplemental Japanese era HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8206120"JDK-8206120 : Add
test cases for lenient Japanese era parsing HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8218915"JDK-8218915 :
Change isJavaIdentifierStart and isJavaIdentifierPart to handle new
code points HYPERLINK
"https://bugs.openjdk.java.net/browse/JDK-8217710"JDK-8217710 : Add 5
currency code points to Java SE 8uX
Webrev:
http://cr.openjdk.java.net/~rpatil/JapaneseEra_and_Currency_changes_8
u
/webrev.00/
These code changes are made possible thanks to specification changes already
pushed:
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/c35f231af17a
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/00475cd329f7
Regards,
Deepak
