On Fri, 1 Mar 2019 at 10:47, Deepak Kejriwal <[email protected]> wrote: > > Hi All, > > > > Please review the back port of fix for JDK-8217609 to 8u-dev:- > > > > JBS report: HYPERLINK > "https://bugs.openjdk.java.net/browse/JDK-%208217609"https://bugs.openjdk.java.net/browse/JDK- > 8217609 > > Webrev: http://cr.openjdk.java.net/~pkoppula/dkejriwal/8217609/webrev.00/ > > Master bug change set: http://hg.openjdk.java.net/jdk/jdk/rev/8ea340a71f17 > > Summary: > Fix is backported from JDK 13 to JDK 8u and is not a clean backport. Reason > for that is because JDK uses CLDR version 21.01 and JDK 13 uses version 33. > Below are the differences between 8u and 13:- > > . The "jp.xml" version of JDK 8u does not contains "<eraNarrow>" node > (<calendar type=japanese">). Therefore "<era type="236">N</era>" which is > part of fix is not added to file. > > . I've commented out one of the test data { LONG, JAPAN, > "\u5143\u53f7" } in "JapaneseEraNameTest.java" for JDK 8u. It checks era > name returned by method "java.util.Calendar.getDisplayName(int field, int > style, Locale locale)" > > o The test fails for this particular data on prior 8u releases across all > existing eras(HEISI,SHOWA,..). > > o The cause of issue is that CLDR java resource file (FormatData_ja.java) > generated by "CLDR Converter" does not contain required resource key > "japanese.long.Eras". The "CLDR Converter" need to be fixed to address this > issue. Since this issue is an existing issue data point { LONG, JAPAN, > "\u5143\u53f7" } is removed from "JapaneseEraNameTest.java" for 8u. > > Regards, > > Deepak > >
Patch looks good to me. Is there a bug/patch to backport to fix the CLDR converter in OpenJDK 8, so japanese.long.Eras are included? JDK-8217609 should have the label 'jdk8u-fix-request' added so it can be approved for 8u. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Web Site: http://fuseyism.com Twitter: https://twitter.com/gnu_andrew_java PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
