Thanks Daniel,
yes, the method naming ship has sailed.
On 03/12/2019 11:44 AM, Daniel Fuchs wrote:
Looks good to me Roger.
It's kind of unfortunate that the process output
is returned by a method named getInputStream(),
even though I understand that's a mirror effect...
best regards,
-- daniel
On 12/03/2019 15:32, Roger Riggs wrote:
Please review a doc fix to refer to the correct method reading from
the process.
diff --git
a/src/java.base/share/classes/java/lang/ProcessBuilder.java
b/src/java.base/share/classes/java/lang/ProcessBuilder.java
--- a/src/java.base/share/classes/java/lang/ProcessBuilder.java
+++ b/src/java.base/share/classes/java/lang/ProcessBuilder.java
@@ -89,7 +89,7 @@ import sun.security.action.GetPropertyAc
* <li><a id="redirect-output">a destination for <i>standard
output</i>
* and <i>standard error</i></a>. By default, the subprocess
writes standard
* output and standard error to pipes. Java code can access these
pipes
- * via the input streams returned by {@link
Process#getOutputStream()} and
+ * via the input streams returned by {@link
Process#getInputStream()} and
* {@link Process#getErrorStream()}. However, standard output and
* standard error may be redirected to other destinations using
* {@link #redirectOutput(Redirect) redirectOutput} and
Issue: https://bugs.openjdk.java.net/browse/JDK-8220237
Thanks, Roger
