Updated: http://cr.openjdk.java.net/~bpb/8219196/webrev.01/

> On Mar 15, 2019, at 1:05 PM, Brian Burkhalter <brian.burkhal...@oracle.com> 
> wrote:
> 
>> On Mar 15, 2019, at 12:57 PM, Roger Riggs <roger.ri...@oracle.com 
>> <mailto:roger.ri...@oracle.com>> wrote:
>> 
>> Looks ok.
>> 
>> In the test, you could probably create the string using.
>>    "\u0800".repeat(size);
> 
> Good idea.
> 
>> Instead of disabling the test statically, you could make it conditional
>> on Runtime.maxMemory but the test will fail quickly anyway.

For this I simply added the requirement to the jtreg tags instead.

>> DataOutputStream.java:
>> 
>> Can you fix the indent lines 387-389, it seems to be only 3 chars.
> 
> Will do.

Thanks,

Brian

Reply via email to