Other than that one, the rest looks good to me. I also tested it and it
works as expected.
+1 (pending the change Semyon noted)
-- Kevin
On 3/28/2019 10:00 AM, semyon.sadet...@oracle.com wrote:
It looks like one was missed:
src/demo/share/jpackage/JNLPConverter/src/jnlp/converter/JNLPConverter.java
609 launchArgs.add("--jvm-args");
--Semyon
On 3/28/19 8:59 AM, Victor D'yakov wrote:
Alexander, Semyon, please review.
Victor
-------- Forwarded Message --------
Subject: RFR: JDK-8221582: Rename jvm-args option to java-options
Date: Thu, 28 Mar 2019 07:07:44 -0400
From: Andy Herrick <andy.herr...@oracle.com>
Organization: Oracle Corporation
To: core-libs-dev <core-libs-dev@openjdk.java.net>
RFR: JDK-8221582: Rename jvm-args option to java-options
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] - https://bugs.openjdk.java.net/browse/JDK-8221582
[2] - http://cr.openjdk.java.net/~herrick/8221582/
/Andy
