The patch looks good (the return statement is missing). Thanks for
fixing it.
Mandy
P.S. Sorry for the belated review. Good to see this pushed. I'm OOO.
On 4/8/19 9:23 PM, Aleksey Shipilev wrote:
On 4/8/19 3:08 PM, David Holmes wrote:
+1
Thanks, I am going to push this under triviality rule.
Strange that an old gcc complains but the newer ones that add more and more
warnings each time, let
this slip through :(
Yeah, compilers :/
Arguably all the exit(-1) in the main method should just be return -1 instead -
but that's a
different matter.
Yes. I submitted https://bugs.openjdk.java.net/browse/JDK-8222120 for other
cases that
(surprisingly) do not break the build (yet?).
-Aleksey
