On 09/04/2019 10:09, Andrew Dinn wrote: > Could I please get a review for the following CSR. It relates to the > change proposed in JDK-8221397 which enables FileChannel > implementation-specific extensions to enum MapMode. > > https://bugs.openjdk.java.net/browse/JDK-8222107 I have updated this CSR to fully detail all the javadoc changes required in FileChannel.impl.
Following Alan Bateman's latest review of the implementation patch there is no need to make the MapMode constructor public. So the only changes required for this CSR are to javadoc. Reviews would be welcome. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander