Thanks Lance.
On 4/10/19 7:00 PM, Lance Andersen wrote:
Looks OK Stuart :-)
On Apr 10, 2019, at 9:22 PM, Stuart Marks <[email protected]
<mailto:[email protected]>> wrote:
Hi all,
Please review this small fix to rmic to make it reject class files that were
compiled with preview features enabled.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8217405
Webrev:
http://cr.openjdk.java.net/~smarks/reviews/8217405/webrev.0/
Note that there is no regression test with this patch; I've added the
noreg-hard label. The main reason is that to test this properly requires
multiple different JDK versions to be available simultaneously, which isn't
supported in out the test environment. One could work around this, e.g. by
constructing class files with the desired version information, from but this
hardly seems worth it for something like rmic.
Thanks,
s'marks
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
