On 4/12/19 4:51 AM, Andy Herrick wrote:
On 4/11/2019 6:06 PM, semyon.sadet...@oracle.com wrote:
On 4/11/19 12:05 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8217895
[2] http://cr.openjdk.java.net/~herrick/8217895/
Andy,
Can I ask you to explain why your fix modifies so many files while
the bug requests a change in help texts?
Shouldn't it be a change in the property bundle? What are those other
changes?
The bug also requests "reducing --identifier option's unused impact".
Part of that (as described in the bugs comments) is that
"app.preferences.id" was written into the cfg file and used by the
native code for functionality no longer present (using the files
generated and read by the preferences api).
Another part of that was native code to handle the (now obsolete) old
form of the cfg file (as a java properties file).
I will add comment in JBS to describe the changes more explicitly.
Ok, thanks. Looks good to me then.
--Semyon
/Andy
--Semyon
/Andy
