Stuart, That looks good.
A tiny note on your FIXME comment [1]: 68 // FIXME: the first paragraph below is copied from Set.equals, because 69 // {@inheritDoc} will include text from Object.equals. You might want to check if it is the same as [2] or [3]. If it is the same, consider adding a reference to the appropriate issue to that FIXME comment for future maintainers. It looks like there are some problems when inheriting documentation from methods defined in java.lang.Object. Thanks, -Pavel ------------------------------------------------------------------------------- [1] http://cr.openjdk.java.net/~smarks/reviews/6394757/webrev.0/src/java.base/share/classes/java/util/AbstractSet.java.sdiff.html [2] https://bugs.openjdk.java.net/browse/JDK-8144034 [3] https://bugs.openjdk.java.net/browse/JDK-6376959