> On May 9, 2019, at 1:47 PM, Roger Riggs <roger.ri...@oracle.com> wrote: > > Hi Bob, > > jdk/internal/platform/cgroupv1/SubSystem.java: > 64: Is that the same as cgroupPath.startsWith(root)? That might be slightly > more readable. >
Sure, that works. I’ll change it. > Regardless, that looks fine. > Thanks, Bob. > Roger > > On 05/08/2019 10:24 AM, Bob Vandette wrote: >> Thanks Misha! >> >> Could I get a “Review” from someone in core libs, please? >> >> Bob. >> >>> On May 7, 2019, at 8:49 PM, mikhailo.seledt...@oracle.com >>> <mailto:mikhailo.seledt...@oracle.com> wrote: >>> >>> Changes look good to me, >>> >>> Misha >>> >>> >>> On 5/7/19 5:56 AM, Bob Vandette wrote: >>>> Please review this change to the Container Metrics implementation. >>>> >>>> Change were made in JDK-8219562 [1] to osContainer_linux.cpp to correct >>>> the parsing of of the /proc/self/mountinfo file but corresponding changes >>>> to the >>>> Metrics API and Container tests shou,d have been done to match this change. >>>> >>>> BUG: >>>> https://bugs.openjdk.java.net/browse/JDK-8221340 >>>> <https://bugs.openjdk.java.net/browse/JDK-8221340> >>>> >>>> WEBREV: >>>> http://cr.openjdk.java.net/~bobv/8221340/webrev.00/ >>>> <http://cr.openjdk.java.net/~bobv/8221340/webrev.00/> >>>> >>>> TESTING: >>>> These changes were verified by running Mach5 tier1 and 2 tests and the >>>> jtreg container >>>> tests on a Linux x64 system. >>>> >>>> [1] https://bugs.openjdk.java.net/browse/JDK-8219562 >>>> <https://bugs.openjdk.java.net/browse/JDK-8219562> >>>> >>>> Bob. >>>> >
