Hi Christoph, The change seems reasonable.
> On May 13, 2019, at 8:14 AM, Langer, Christoph <christoph.lan...@sap.com> > wrote: > > Hi, > > please review this fix of a regression in zipfs after JDK-8222532 [0]. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8223597 > <https://bugs.openjdk.java.net/browse/JDK-8223597> > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/ > <http://cr.openjdk.java.net/~clanger/webrevs/8223597.0/> > > The issue occurs when an empty file/channel is persisted into a zip file. The > entry had already been compressed with CRC of 0 at the time the output stream > to the zipfs was closed. But when the Entry is eventually synced to the zip > file, this is not detected and the bytes get compressed again. > > The test was adapted to reliably provoke this intermittent error. In the test > I also suppressed printout of an expected Exception to avoid some distraction > when reading its JTR files. > > Thanks > Christoph > > [0] https://bugs.openjdk.java.net/browse/JDK-8222532 > <https://bugs.openjdk.java.net/browse/JDK-8222532> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
