Thanks Lance! Yikes, forgot the copyright header. The factory files are updated to 2019 now. The test file was okay as it was changed recently.

http://cr.openjdk.java.net/~joehw/jdk13/8219692/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk13/8219692/webrev/>

Best,
Joe

On 5/20/19, 4:09 PM, Lance Andersen wrote:
Hi Joe,

As we discussed off-line, these changes look OK. Please double check that the copyright is updated in the relevant files.

Best
Lance
On May 20, 2019, at 7:06 PM, Joe Wang <huizhe.w...@oracle.com <mailto:huizhe.w...@oracle.com>> wrote:

Please review an enhancement to the DOM and SAX factories. By default, DOM/SAX factories created using the existing newInstance methods do not support XML Namespace. Parsers instantiated with such factories would therefore ignore namespaces. Users not realizing or unaware of the legacy setting may run into the issue as demonstrated in the bug description.

This patch addresses the issue by introducing new methods that must set NamespaceAware to true. Factories instantiated using these methods can therefore create parsers that support XML Namespace by default.

JBS: https://bugs.openjdk.java.net/browse/JDK-8219692
webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8219692/webrev/ <http://cr.openjdk.java.net/%7Ejoehw/jdk13/8219692/webrev/>

Thanks,
Joe

<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>



Reply via email to