Hi, Andrew
I tried to test these changes and build failed on all systems except Linux
because:
workspace/open/src/hotspot/share/prims/unsafe.cpp:446:3: error: use of
undeclared identifier 'JNU_ThrowRuntimeException'
JNU_ThrowRuntimeException(env, "writeback is not implemented");
^
workspace/open/src/hotspot/share/prims/unsafe.cpp:447:10: error: use of
undeclared identifier 'IOS_THROWN'
return IOS_THROWN;
^
workspace/open/src/hotspot/share/prims/unsafe.cpp:473:3: error: use of
undeclared identifier 'JNU_ThrowRuntimeException'
JNU_ThrowRuntimeException(env, "writeback sync is not implemented");
^
workspace/open/src/hotspot/share/prims/unsafe.cpp:474:10: error: use of
undeclared identifier 'IOS_THROWN'
return IOS_THROWN;
^
workspace/open/src/hotspot/share/prims/unsafe.cpp:488:3: error: use of
undeclared identifier 'JNU_ThrowRuntimeException'
JNU_ThrowRuntimeException(env, "writeback sync is not implemented");
^
workspace/open/src/hotspot/share/prims/unsafe.cpp:489:10: error: use of
undeclared identifier 'IOS_THROWN'
return IOS_THROWN;
------------------------------------------------------------
Also Graal test should be fixed for new intrinsics (add them to
'toBeInvestigated' for isJDK13orHigher):
src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java
java.lang.AssertionError: missing Graal intrinsics for:
jdk/internal/misc/Unsafe.writeback0(J)V
jdk/internal/misc/Unsafe.writebackPostSync0()V
jdk/internal/misc/Unsafe.writebackPreSync0()V
at
org.graalvm.compiler.hotspot.test.CheckGraalIntrinsics.test(CheckGraalIntrinsics.java:653)
Regards,
Vladimir
On 5/29/19 5:50 AM, Andrew Dinn wrote:
Hi Alan,
Apologies for the previous post which escaped from the lab while Dr
Funkenstein was struggling to push the right buttons (and work out what
happened when he pushed them).
I have created an implementation subtask and associated CSR. I also
updated the last webrev to record the javadoc changes necessitated in
order to complete the CSR. Finally, I set the JEP fix version to 13 and
pressed the big red "target" button.
Impl JIRA: https://bugs.openjdk.java.net/browse/JDK-8224974
CSR JIRA: https://bugs.openjdk.java.net/browse/JDK-8224975
webrev: http://cr.openjdk.java.net/~adinn/8224974/webrev.02/
n.b. I have switched to using the subtask JIRA id in $title and in the
cr.openjdk webrev link ...
regards,
Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
