Thanks, Lance.
Sure, will update the test case with @summary.
Naoto
On 5/29/19 2:21 PM, Lance Andersen wrote:
Hi Naoto,
This is OK.
Could you please add an @summary as it is missing so that we are
consistent with other tests.
No need to spin a webrev again though
Best
Lance
On May 29, 2019, at 5:12 PM, [email protected]
<mailto:[email protected]> wrote:
Hi,
Please review the fix for the following issue:
https://bugs.openjdk.java.net/browse/JDK-8223773
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8223773/webrev.00/
Checking the range of HourOfAmPm with the range of AmPmOfDay is
apparently incorrect. Fixing it will change the behavior of parsing
with SMART resolver style to throw a DateTimeParseException. This is a
change in which an app will start to see an exception with incorrect
data, but that is what should be in the first place.
Naoto
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen|
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
