On 6/3/19 10:06 PM, David Holmes wrote:
Hi Mandy,
Functional fix looks good, but layout and indentation appears off in
the diff.
Hmm.. I'll check and fix that up before pushing it.
Thanks to Alan for the time spent investigating this!
Indeed.
Mandy
Thanks,
David
On 4/06/2019 1:02 pm, Mandy Chung wrote:
test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java time out
in certain configuration e.g. fastdebug -Xcomp. Setting the empty class
path significantly improves the execution time as it eliminates opening
and scanning of the JAR files on the class path. Alan has also
experimented
it on Windows machine.
diff --git
a/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
b/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
--- a/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
+++ b/test/jdk/java/lang/reflect/PublicMethods/PublicMethodsTest.java
@@ -222,6 +222,11 @@
StandardJavaFileManager standardJavaFileManager =
javac.getStandardFileManager(errorsCollector, Locale.ROOT,
Charset.forName("UTF-8"));
+ try {
+ standardJavaFileManager.setLocation(StandardLocation.CLASS_PATH,
List.of());
+ } catch (IOException e) {
+ throw new UncheckedIOException(e);
+ }
TestFileManager testFileManager = new TestFileManager(
standardJavaFileManager, source);
Mandy
