Looks okay.
Just to mention the alternativ: we could add "@requires !vm.aot.enabled"
in those tests if only a few.
Mandy
On 6/4/19 7:29 PM, Mikael Vidstedt wrote:
I, too, agree. :)
New webrev which adds a new ProblemList-aot.txt to be used when
running tests with AOT.
Webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.01/open/webrev/
Cheers,
Mikael
On Jun 4, 2019, at 3:18 PM, Mandy Chung <mandy.ch...@oracle.com
<mailto:mandy.ch...@oracle.com>> wrote:
I agree with Igor. The best is to keep running these tests except
the AOT, perhaps + fastdebug, run only.
Mandy
On 6/4/19 2:06 PM, Igor Ignatyev wrote:
Hi Mikael,
as it looks like 8222445 isn't going to be fixed for a long time (as it's
"targeted" to tbd), and the defect seems to affect only AOT run, I don't think
it's a good idea to put these tests into a general problem list. I'd suggest to either
create aot-specific problem list or put them into -graal specific problem list.
-- Igor
On Jun 4, 2019, at 1:38 PM, Mikael Vidstedt<mikael.vidst...@oracle.com> wrote:
The following java/lang/invoke/VarHandles tests frequently fail when run with AOT.
Untilhttps://bugs.openjdk.java.net/browse/JDK-8222445
<https://bugs.openjdk.java.net/browse/JDK-8222445> has been fixed they should
be problem listed.
java/lang/invoke/VarHandles/VarHandleTestByteArrayAsShort.java
java/lang/invoke/VarHandles/VarHandleTestByteArrayAsChar.java
java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java
bug:https://bugs.openjdk.java.net/browse/JDK-8225305
<https://bugs.openjdk.java.net/browse/JDK-8225305>
webrev:http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.00/open/webrev/
<http://cr.openjdk.java.net/~mikael/webrevs/8225305/webrev.00/open/webrev/>
Cheers,
Mikael
