Andy,
I was just curios why we don't use Paths. If we should then I'll use
this API in my patches. I didn't mean to ask you do the clean up in all
the sources :)
- Alexey
On 6/13/2019 3:34 PM, Andy Herrick wrote:
On 6/13/19, 2:00 PM, Alexey Semenyuk wrote:
Looks good.
Q: any good reason we are not using
Paths.get(a, b, c)
instead of
a + File.separator + b + File.separator + c
to build paths?
There are a lot of places we should be using Paths instead of String
and File objects, but JPackagePath (test helper) is among the worst of
the offenders. I will make a pass at cleaning that up and any other
such places this change set is touching.
/Andy
- Alexey
On 6/13/2019 1:21 PM, Andy Herrick wrote:
Sorry - subject was missing, this is for: JDK-8225569: jpackage
app-image layout
/Andy
On 6/13/2019 12:59 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8225569
[2] http://cr.openjdk.java.net/~herrick/8225569/webrev.01/
<http://cr.openjdk.java.net/%7Eherrick/8225569/webrev.01/>
/Andy