Hi Vicente,
This looks fine.
Nit: the new test line 71 and 80 have an extra space "Error (" that can
be taken out.
Mandy
On 6/24/19 8:33 PM, Vicente Romero wrote:
Please review fix for [1], at [2]. The implementation of method
MethodTypeDesc.resolveConstantDes is not in sync with its
specification. In particular where it says [3]:
Resolves this descriptor reflectively, emulating the resolution
behavior of JVMS 5.4.3 and the access control behavior of JVMS 5.4.4.
The resolution and access control context is provided by the
MethodHandles.Lookup parameter.
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8226709
[2] http://cr.openjdk.java.net/~vromero/8226709/webrev.00/
[3]
http://hg.openjdk.java.net/jdk/jdk/file/ae2e53e379cb/src/java.base/share/classes/java/lang/constant/ConstantDesc.java#l89
