Hi Lance, > On Jul 15, 2019, at 1:33 PM, Lance Andersen <lance.ander...@oracle.com> wrote: > > Is there an existing CSR or are you waiting for the review to complete here?
The latter. > Overall, I think it is OK. > > The existing autoflush wording looks like it could use some wordsmithing at > some point (as I know we do this a little differently in some of the APIs ) > > - “A boolean” not sure we need to state this as it is obvious from the > declaration. It looks like here one could change "A boolean; if true,” to simply “Whether”. > - Some places in the JDK, we say True if XXXX; false otherwise. I am not > sure how many APIs after the really early ones start with “if true…” > > Anyways, something to consider for a future todo list I guess :-) Might be worth doing. I’ll after any other comments come in. Thanks, Brian
