Hi Brian > On Jul 17, 2019, at 4:39 PM, Brian Burkhalter <brian.burkhal...@oracle.com> > wrote: > > Hi Lance, > >> On Jul 17, 2019, at 1:02 PM, Lance Andersen <lance.ander...@oracle.com >> <mailto:lance.ander...@oracle.com>> wrote: >> >> I think what you have is fine, a unique test in each subdirectory as it is >> organized by class. What you might consider is having a generic NPE Test >> class, which validates the error for Constructors and methods as described >> in the package javadoc. Maybe this is a TBD, but if you decide that is a >> good idea, consider renaming the test now to maybe NPETests.java > > I merged the two tests into one and converted to TestNG [1]. There is > precedent for having a test which deals with multiple classes in > test/jdk/java/io [2].
Thanks for the pointer. Looks fine and You are good to go….. I guess the next question(here he goes again ;-) is do you want to test all of the constructors such as BufferedInputStream(InputStream, int) or just one per class? I realize the BufferedInputStream(InputStream) just calls into BufferedInputStream(InputStream, int). Sorry for the continual questions and extra work Best Lance > > Thanks, > > Brian > > [1] http://cr.openjdk.java.net/~bpb/8067801/webrev.01/ > <http://cr.openjdk.java.net/~bpb/8067801/webrev.01/> > [2] test/jdk/java/io/NegativeInitSize.java <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
