On 22/07/2019 10:12, Severin Gehwolf wrote:
:
Take 03:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8228434/03/webrev/
This now reverts Platform.java changes to the version prior JDK-
8227642, introduces a Container class with one constant,
CONTAINER_ENGINE, and renames the jdk.test.docker.command property to
jdk.test.container.command.
Breakage as seen via jdk/net/Sockets/Test.java no longer exists as the
Platform class no longer loads an extra property.
Testing: jdk/net/Sockets/Test.java test, container tests with
docker/podman on Linux x86_64.
Thoughts?
This looks okay, assuming that none of the container/docker tests uses a
security manager. If they do (and maybe it's a tax on the first test to
do us), then the System.getProperty in Container will need to read the
value of the property in a privileged block to void the tests needing to
grant the permission.
Given that the Sockets test is failing for everyone since JDK-8227642, I
think it should be okay to push what you have. Further cleanup can be
done latter.
-Alan
