On 7/25/2019 5:29 PM, Alexander Matveev wrote:
Do you know if all 32-bit builds will have "_JLI_Launch@56"?
Also, I think @56 is ordinal which can be used to load function by
this number instead of the name, so I do not think you need to specify
it.
My suggestion is to try "JLI_Launch" first and then "_JLI_Launch" and
then "_JLI_Launch@56", if we doing 32-bit build.
Thanks,
Alexander
Oracle does not support, build, or test the jdk (or jpackage in
particular) on 32 bit platforms, nor use jpackage to package 32 bit apps.
We will take submitted fixes (such as this one) from others who do use
32 bit builds, provided they do not break our 64 bit builds in any way.
That being said I think we should take this fix "as is", and allow
Robert (or any other contributor who is using 32 bits) to propose any
further 32 bit related changes,
/Andy
On 7/25/2019 8:22 AM, Kevin Rushforth wrote:
It looks fine.
-- Kevin
On 7/25/2019 6:20 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8227684
[2] http://cr.openjdk.java.net/~herrick/8227684/webrev.01/
Submitted by: Robert Lichtenberger
/Andy
